Conversation
… None and do not clean up remainder - add test cases for nested dict in the unit test
…ttps://github.com/leaf-ai/neuro-san into fix-structure-format-make-thinking-file-incomplete
Noravee
commented
Jul 30, 2025
|
|
||
| return structure | ||
|
|
||
| def _extract_delimited_block(self, text: str, delimiters: Dict[str, str]) -> Tuple[Optional[str], str]: |
Collaborator
Author
There was a problem hiding this comment.
New extraction logic.
Noravee
commented
Jul 30, 2025
| self.assertIsNotNone(remainder) | ||
| self.assertEqual(remainder, "") | ||
|
|
||
| def test_json_backtick_nested_no_remainder(self): |
Collaborator
Author
There was a problem hiding this comment.
New test case for nested dictionary.
d1donlydfink
approved these changes
Jul 30, 2025
Collaborator
d1donlydfink
left a comment
d1donlydfink
left a comment
There was a problem hiding this comment.
Nice to see new tests and existing test passing. Nice job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The expected output was:
{'running_cost': '0.00', 'origin': [{'tool': 'MusicNerdPro', 'instantiation_index': 1}, {'tool': 'Accountant', 'instantiation_index': 1}], 'origin_str': 'MusicNerdPro.Accountant'}
But the actual output was:
{'tool': 'Accountant', 'instantiation_index': 1}
This discrepancy occurs because the current logic in
JsonStructureParserdoes not correctly handle nested dictionaries when extracting structured information.Fix
Update the implementation of
JsonStructureParser.parse_structure()to correctly handle and extract nested dictionary structures.Test
Manually ran
music_nerd_proand verified that the parsed structure now matches the expected format.